-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unmaintained audit warning for yaml-rust #544
base: master
Are you sure you want to change the base?
Fix unmaintained audit warning for yaml-rust #544
Conversation
I really need to check the PR tracker first, as there is already a PR for this with #538. Maintainers' call as to which PR to use. |
I've looked at the others and I think this PR is the one to use. Can you fix the CI failure please? Note to self: There is no Cargo.lock diff since there is no Cargo.lock. |
Failures for 2 of the steps are saying Also, I'm not sure what to do about the minimum supported rust version test. |
If the yaml specification and version of the yaml file hasn't changed, why is it reporting a parse error I wonder when it didn't before? |
Is that file supposed to be generated? I don't see anyhthing in that directory. |
It will appear when you checkout the git submodules |
I did some investigation and it turns out %YAML 1.2
---
# actual content here It is also unable to parse I'll open an issue on the library's repository. |
If you were using |
Feel free to bump MSRV if needed |
Hi! |
@Ethiraric I forgot about this PR. I'll squeeze some time in this week to see if there's anything I can address on my end to get the build passing. |
When running
cargo audit
on this repo, I get a warning thatyaml-rust
is no longer maintained:This PR replaces that dependency with
yaml-rust2
, which does the same thing and has the same API, but is also actively maintained.Some other warnings popped up as well, but they were related to dev dependencies, so likely not a big deal.